Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read-only EditorSpinSlider display #80544

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

MewPurPur
Copy link
Contributor

Prevents these things from being displayed in read-only spinsliders.

image

Advances godotengine/godot-proposals#6988 a little.

@MewPurPur MewPurPur force-pushed the buff-editorspinslider-2 branch from 66e7605 to fac939b Compare August 12, 2023 12:30
@RedMser
Copy link
Contributor

RedMser commented Aug 12, 2023

Without the grabber showing, there is no indication of the slider's current value in relation to its minimum/maximum values. So if you e.g. see a 0 you don't know if the slider also accepts negative values, or if it's on the minimum already.
Would it maybe possible to reduce the opacity instead of completely hiding it, so it's clear you can't edit it?
Then again I can't think of many cases where a slider is read-only in the UI, so maybe it's not important.

@MewPurPur
Copy link
Contributor Author

@RedMser It's only the grabber that doesn't show, the rest of the slider does.

@MewPurPur
Copy link
Contributor Author

Poke poke. Should be an easy merge, nothing can really go wrong here.

@akien-mga
Copy link
Member

I would suggest rebasing for good measure, it's been 6 months.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 9, 2024
@akien-mga akien-mga merged commit d584ce0 into godotengine:master Feb 9, 2024
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the buff-editorspinslider-2 branch February 9, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants