Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change documentation spelling of macOS key 'Command' to match guidelines #80567

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

Alex2782
Copy link
Member

Use the compact form for modifier keys (Ctrl/Cmd) instead of their spelled out form (Control/Command)

https://docs.godotengine.org/en/latest/contributing/documentation/docs_writing_guidelines.html#keyboard-shortcut-guidelines

@Alex2782 Alex2782 requested a review from a team as a code owner August 12, 2023 22:31
@AThousandShips
Copy link
Member

AThousandShips commented Aug 13, 2023

You shouldn't change the .po files directly, they are generated, this file needs to be reset, see here

@Alex2782
Copy link
Member Author

ok now Files changed 1

@AThousandShips
Copy link
Member

Please squash your commits into one, see here, please update your commit message to make it clear what you have done, something like "Replaced Command with Cmd in documentation"

@Alex2782 Alex2782 force-pushed the keyboard_shortcut_guidelines branch from 23eee7d to 6e2b311 Compare August 13, 2023 21:57
@Alex2782
Copy link
Member Author

Ok maybe now. Edit the XML file took only 10 seconds. Use Git properly about 20 minutes 😅

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 13, 2023
@akien-mga akien-mga changed the title [DOCS] Keyboard shortcut guidelines, MacOS key 'Command' Change documentation spelling of macOS key 'Command' to match guidelines Aug 17, 2023
@akien-mga akien-mga merged commit 391c51a into godotengine:master Aug 17, 2023
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Alex2782 Alex2782 deleted the keyboard_shortcut_guidelines branch March 27, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants