Fix version check for GDExtension

[AThousandShips]

The version check only checks individual entries, not lexicographical comparison, this would cause a plugin requiring at least "4.1.1" to fail if you are on "4.2.0"

(Not technically needed for 4.1 as the condition won't be true there)

Could alternatively be written as:

if (VERSION_MAJOR != compatibility_minimum[0]) {
	compatible = VERSION_MAJOR > compatibility_minimum[0];
} else if (VERSION_MINOR != compatibility_minimum[1]) {
	compatible = VERSION_MINOR > compatibility_minimum[1];
} else {
	compatible = VERSION_PATCH >= compatibility_minimum[2];
}

[akien-mga]

Seems fine.

Could use VERSION_HEX alternatively for a simple comparison:

godot/core/version.h

Line 55 in 7ba79d6

#define VERSION_HEX 0x10000 * VERSION_MAJOR + 0x100 * VERSION_MINOR + VERSION_PATCH

[Bromeon]

Also, for lexicographical comparison, std::make_tuple(l0, l1, l2) < std::make_tuple(r0, r1, r2) is usually a good trick.

In this case, the hex comparison seems simpler though.

[AThousandShips]

Oh I'd have used that if I were to use the standard library

Can switch to the hex comparison if desired when I have the time, probably tomorrow

[Sslaxx]

Fixes #80590?

[AThousandShips]

Don't think so, they are on 4.1.1 and the check won't fail for them

[dsnopek]

Thanks!

I think any of the variations discussed here would be fine, including the one currently used in the PR.

[Gallilus]

Seems to make sense.
Only check sub_versions if you are on the relevant branch.
If we are in a newer major version it should be compatible.

Out of the scope of this bug fix but the only thing I can think of is that we are not supporting backporting compatibility.

I will mention that in Rocket Chat.

THANKS

[AThousandShips]

Switched check to my OP suggestion, to match the one used in godotengine/godot-cpp#1208

[akien-mga]

Thanks!

[AThousandShips]

Thank you!

[YuriSizov]

Cherry-picked for 4.1.2.