Fix memory access error for MultiMesh with GLES3
#80788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer was incorrectly assigned when invalid data was provided
clayjohn
added
the
cherrypick:4.1
|
Thanks! |
|
Thank you! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer was incorrectly assigned when invalid data was provided
Can confirm the data is no longer garbled, but haven't got a sanitiser build to confirm it doesn't crash, as it doesn't crash for me with the original code
Can move it before the "make local" function if safe to save on processing but left it after for now
Edit: Can confirm this fixes memory issues, tested with
set_instance_transform_2dwhich crashes on the old code but not the newMultiMesh._get_transform_2d_arrayfunction in GLES3 crashes Godot #80785