Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skeletons when generating multiple Godot scenes from one GLTF #80831

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix skeletons when generating multiple Godot scenes from one GLTF #80831

merged 1 commit into from
Sep 29, 2023

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Aug 20, 2023 •
edited
Loading

Fixes #80832.

@aaronfranke aaronfranke added this to the 4.x milestone Aug 20, 2023
@aaronfranke aaronfranke mentioned this pull request Aug 20, 2023
Closed
@aaronfranke aaronfranke force-pushed the gltf-skel-gen-multi-scene branch from 922f532 to f4ed91c Compare August 20, 2023 20:43
@aaronfranke aaronfranke force-pushed the gltf-skel-gen-multi-scene branch from f4ed91c to 2ebef16 Compare September 17, 2023 02:25
@aaronfranke aaronfranke marked this pull request as ready for review September 17, 2023 05:14
@aaronfranke aaronfranke requested a review from a team as a code owner September 17, 2023 05:14
@aaronfranke aaronfranke modified the milestones: 4.x, 4.2 Sep 17, 2023
Scoppio
Scoppio approved these changes Sep 26, 2023
View reviewed changes
Copy link

@Scoppio Scoppio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the issue presented and it does fix it, also I appreciate the use of very specific error messages instead of a generic message, helps alot to understand what is happening and what could be the problem.

@aaronfranke aaronfranke force-pushed the gltf-skel-gen-multi-scene branch from 2ebef16 to 7bd894b Compare September 28, 2023 22:49
fire
fire approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Community testing suggests that it is working and Aaron has done his testing so it looks good, but I am not able to fully test this myself.

@aaronfranke
Copy link
Member Author

I did re-test this tonight using the reproduction project in #80832 and it still works, and also I tested on The Mirror.

@akien-mga akien-mga merged commit 7f179e4 into godotengine:master Sep 29, 2023
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the gltf-skel-gen-multi-scene branch September 29, 2023 15:03
@matheusmdx matheusmdx mentioned this pull request May 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scoppio Scoppio Scoppio approved these changes

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug topic:import topic:3d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Error when generating multiple Godot scenes from one GLTFState
4 participants
@aaronfranke @akien-mga @fire @Scoppio