-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify right-click track insertion code #80860
Simplify right-click track insertion code #80860
Conversation
d8f47b1
to
970be7a
Compare
@RandomShaper Did you mean to close this? Seems like you force pushed a no-op branch to your PR branch, which closed it. |
No, I didn't. Thanks for letting me know. According to Git, everything was up-to-date regardless I had a diverging local commit. I've rebased and re-pushed and it looks good now. |
Poke @TokageItLab |
I just tested this. And it creates the Reset animation and adds the track the first time I add a new animation property and add a key to it, but any subsequent tracks with keys I add don't get added to the Reset animation. godot.windows.editor.x86_64_Fnvfbqp4sZ.mp4 |
I guess I need to rebase this. Involved code likely changed a lot since the last push. |
6623d88
to
b2e0bc4
Compare
I've rebased, but I'm not sure if other code involved has changed in a way that further changes are required, so TIWAGOS. |
b2e0bc4
to
9ba984e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (rebased on top of master
71699e0), it works as expected. I tested this with various track types (Property, 3D Rotation/Position/Scale, Audio and so on). Automatically added tracks from the inspector still work correctly.
Code looks good to me.
Thanks! |
The code path used for context-menu track insertion hadn't reset logic implemented. This PR refactors it so it uses the already existing code paths and also avoids some repetition even in the code that remains. The only things preventing this PR from being a true refactor are these:
RESET
track is not created (or properties added) if used Right ClickInsert Key
in timeline. #55438).TYPE_BLEND_SHAPE
andTYPE_VALUE
use to include_clear_selection_for_anim()
in their undo script. I'm not sure how safe is to stop doing that.Fixes #55438.
I've smoke-tested this, but this definitely needs more testers.