Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing decal mask in mobile renderer #80911

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

BastiaanOlij
Copy link
Contributor

This PR adds a missing decal mask check back into the mobile renderer.

Fixes #70774

@BastiaanOlij BastiaanOlij added bug topic:rendering topic:3d cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 23, 2023
@BastiaanOlij BastiaanOlij added this to the 4.2 milestone Aug 23, 2023
@BastiaanOlij BastiaanOlij requested a review from a team as a code owner August 23, 2023 01:15
@BastiaanOlij
Copy link
Contributor Author

Possibly also cherry pick this for 4.0 if we do another 4.0?

@BastiaanOlij BastiaanOlij self-assigned this Aug 24, 2023
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 6758a7f), it works as expected.

@YuriSizov
Copy link
Contributor

if we do another 4.0?

We probably won't, there isn't much demand for it.

@YuriSizov YuriSizov merged commit cae4319 into godotengine:master Aug 25, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@BastiaanOlij BastiaanOlij deleted the fix_decal_mask_mobile branch July 10, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan Mobile: Decals are applied to the 3D manipulation gizmo
3 participants