-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added checks to remove meta arrays when creating and undoing guides #81011
Conversation
This was a solution already opened: Though this adds a further case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When pushing you should do git push -f
to avoid the merge commits you create
3ab1580
to
24ccbdb
Compare
Thanks a ton for the help! This is my first open source contribution, so I don't really have much experience. I squashed and force-pushed the commits, so please let me know if there is anything else I need to do. |
You need to squash again, you have three commits |
Added checks to remove meta arrays when creating and undoing guides Update editor/plugins/canvas_item_editor_plugin.cpp Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> Update editor/plugins/canvas_item_editor_plugin.cpp Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
9a2cda9
to
a7b2819
Compare
Alright, I did it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
On a side note, it might be worth adding some remove_guide()
method to clean this up. That's for another PR though.
I certainly thought about it, but decided against it since I didn't want to change the code too radically for the time being. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Metadata arrays are now correctly removed after executing the steps from #80947 for the horizontal guide, vertical guide, and in the case of both being used.