-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure OpenXR classes are declared properly #81037
Conversation
AThousandShips
commented
Aug 27, 2023
•
edited by akien-mga
Loading
edited by akien-mga
- Fixes: Object is many times heavier than Node or RefCounted...? #81014
- Fixes: Custom objects are slower to instantiate in Godot 4.0 GDScript compared to Godot 3.5.1 #73936
- Fixes: Object allocation is slower since 4.0.beta9 #70853
Copying my question from the other PR: @BastiaanOlij Since we're exposing this class properly now, it's worth thinking about the name. We use "metadata" as a single word throughout the Godot API, and this one is the only one using "meta data" ( Is this a name derived from the OpenXR API, or something we chose ourselves? If the latter, it could be worth standardizing on |
@akien-mga nope, thats just me not knowing we wrote that as one word :) I'm more than happy with that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just akiens requested change to make meta data -> metadata
8d1c570
to
adc9a4b
Compare
Done! Renamed the file in question, to match the spelling |
There's a use of "meta data" in the doc file, which would be worth changing too. Actually, there's a few more, most in OpenXR code, which we could change:
(the And finally, I also noticed that the doc file is in the wrong folder. It should be moved to the module's Edit: Actually, those three should move:
|
Got it! |
adc9a4b
to
5483412
Compare
I believe that's all now |
Co-authored-by: Bastiaan Olij <mux213@gmail.com>
5483412
to
c23bd8b
Compare
Thanks! |
Thank you! |
Cherry-picked for 4.1.2. |