Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting TabContainer's font_hovered_color theme property #81040

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

Ymanawat
Copy link
Contributor

@Ymanawat Ymanawat commented Aug 27, 2023

PRs target 4.x if the same change was done in master, having the same issue in 4.0 stable as well.
This resolves the issue of not setting the tab's font_hovered_color by theme override as mentioned in #80989

@Ymanawat Ymanawat requested a review from a team as a code owner August 27, 2023 12:35
@AThousandShips AThousandShips added this to the 4.2 milestone Aug 27, 2023
Copy link
Member

@YeldhamDev YeldhamDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akien-mga akien-mga changed the title Fixed not setting tab's font_hovered_color by theme Fix setting TabContainer's font_hovered_color theme property Aug 28, 2023
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@YuriSizov
Copy link
Contributor

Please amend your commit message, though. You can use the current title of this PR for example.

@Ymanawat
Copy link
Contributor Author

@YuriSizov is it okay now?

@YuriSizov
Copy link
Contributor

Yes, perfect!

@akien-mga akien-mga merged commit ae7bab8 into godotengine:master Aug 31, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Aug 31, 2023
@Ymanawat Ymanawat deleted the control-theme-80989 branch September 1, 2023 14:27
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set tab's hover color by theme
5 participants