-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting TabContainer's font_hovered_color
theme property
#81040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
font_hovered_color
by themefont_hovered_color
theme property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
Please amend your commit message, though. You can use the current title of this PR for example. |
9d5d245
to
d7bf05b
Compare
@YuriSizov is it okay now? |
Yes, perfect! |
Thanks! |
Cherry-picked for 4.1.2. |
PRs target
4.x
if the same change was done inmaster
, having the same issue in4.0 stable
as well.This resolves the issue of not setting the tab's
font_hovered_color
by theme override as mentioned in #80989