Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison of Callables with binds #81131

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fix comparison of Callables with binds #81131

merged 1 commit into from
Sep 1, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips added bug topic:core cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 29, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Aug 29, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner August 29, 2023 14:12
@akien-mga akien-mga requested a review from KoBeWi August 29, 2023 14:35
@akien-mga akien-mga merged commit bbdd1aa into godotengine:master Sep 1, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the callable_fix branch September 1, 2023 14:12
@AThousandShips
Copy link
Member Author

Thank you!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Inconsistent Signal.is_connected behaviour for callables that combine bind and unbind
4 participants
@AThousandShips @akien-mga @YuriSizov @KoBeWi