Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grayscale DDS loading #81134

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Fix grayscale DDS loading #81134

merged 1 commit into from
Aug 29, 2023

Conversation

BlueCube3310
Copy link
Contributor

@BlueCube3310 BlueCube3310 commented Aug 29, 2023 •
edited
Loading

Fix for l8/l8a8 dds loading (#80669, #80862) updated for the revert in #81126.

@BlueCube3310 BlueCube3310 requested a review from a team as a code owner August 29, 2023 17:26
@akien-mga akien-mga added bug topic:rendering topic:import cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 29, 2023
@akien-mga akien-mga added this to the 4.2 milestone Aug 29, 2023
@akien-mga akien-mga changed the title Fix grayscale dds loading Fix grayscale DDS loading Aug 29, 2023
clayjohn
clayjohn approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@akien-mga akien-mga merged commit a6d3114 into godotengine:master Aug 29, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@BlueCube3310 BlueCube3310 mentioned this pull request Aug 30, 2023
Merged
@BlueCube3310 BlueCube3310 mentioned this pull request Sep 12, 2023
Merged
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@BlueCube3310 BlueCube3310 deleted the Dds-lum-revert branch April 25, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:import topic:rendering
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@BlueCube3310 @akien-mga @YuriSizov @clayjohn