Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCons: Add option for MSVC incremental linking. #81144

Merged
merged 1 commit into from
Aug 31, 2023
Merged

SCons: Add option for MSVC incremental linking. #81144

merged 1 commit into from
Aug 31, 2023

Conversation

anvilfolk
Copy link
Contributor

@anvilfolk anvilfolk commented Aug 29, 2023 •
edited
Loading

Build times roughly doubled for me but not a lot of other people without incremental linking with MSVC from an updated Visual Studio Community 2022 with #80482.

Before #80482:

1>scons: done building targets.
1>[Time elapsed: 00:00:17.002]

After:

1>scons: done building targets.
1>[Time elapsed: 00:00:49.474]

This PR creates the incremental_link option which remains off by default but can be enabled.

@anvilfolk anvilfolk requested a review from a team as a code owner August 29, 2023 22:03
@anvilfolk anvilfolk force-pushed the incremental-option branch 3 times, most recently from b66356b to 2501950 Compare August 29, 2023 22:24
@anvilfolk anvilfolk requested a review from a team as a code owner August 29, 2023 22:24
@Calinou Calinou added this to the 4.x milestone Aug 29, 2023
@anvilfolk anvilfolk mentioned this pull request Aug 30, 2023
Merged
bruvzg
bruvzg approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's working in some cases, then why not. It's always better to have options.

@akien-mga akien-mga changed the title Build system: add option for MSVC incremental linking. SCons: Add option for MSVC incremental linking. Aug 31, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 31, 2023
@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 31, 2023
@akien-mga akien-mga merged commit 46ff9aa into godotengine:master Aug 31, 2023
@akien-mga
Copy link
Member

Thanks!

@anvilfolk anvilfolk deleted the incremental-option branch August 31, 2023 12:15
@akien-mga
Copy link
Member

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 6, 2023
@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Sep 6, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement performance platform:windows topic:buildsystem
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@anvilfolk @akien-mga @YuriSizov @bruvzg @Calinou