Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Texture2D and Texture3D icons #81169

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

MewPurPur
Copy link
Contributor

Texture2D and Texture3D have quite established shapes, so I think we should make use of it for the abstract classes, to help with visual grepping when they're folded in the Create dialog.

image

@MewPurPur MewPurPur requested a review from a team as a code owner August 30, 2023 14:41
@YuriSizov YuriSizov added this to the 4.2 milestone Aug 30, 2023
@AThousandShips AThousandShips added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Oct 27, 2023
@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 27, 2023
@YuriSizov
Copy link
Contributor

Could you force-push your PR so the CI runs again?

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Note that Texture2DRD and Texture3DRD are missing icons (RD stands for RenderingDevice):

image

image

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Dec 7, 2023

Godot has R-dimensional textures now? :O

No idea what these are or what would work for them. Hmu if you have ideas or if you can suggest something.

@Riteo
Copy link
Contributor

Riteo commented Dec 7, 2023

@MewPurPur

Godot has R-dimensional textures now? :O

RD stands for RenderingDevice as @Calinou pointed out.

Based on the docs it looks like they reference a texture created directly on the RenderingDevice, so it's some low-level thing I suppose.

I'm not really sure how that could be conveyed. Maybe you could draw "RD" inside, somehow pair it to a GPU symbol (I think that'd be a fair generalization) or maybe an arrow, to represent that it's actually somewhere else?

@MewPurPur
Copy link
Contributor Author

I was making a joke 😓

The GPU thingy sounds interesting, but I realized we don't have any kind of common convention for it. CPU has one (on CPUParticles) which would've been cool, but... yeah it's an association with CPUs, I think it wouldn't be ugly, but it's wrong in a way that would irk people easily. GPUs don't seem to have any conventional icons people would find familiar as far as I see. So as I see it, I'll have to think of something more abstract to do for it and its 3D analogue.

@YuriSizov YuriSizov merged commit aec890b into godotengine:master Dec 8, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@MewPurPur MewPurPur deleted the texture-abstract-icons branch December 8, 2023 18:31
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants