Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TreeItem range slider not working properly #81174

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

BlueCube3310
Copy link
Contributor

@BlueCube3310 BlueCube3310 commented Aug 30, 2023

Fixes #80556 (partially).

TreeItem's value_editor_changed function incorrectly changes the multiline text editor's text when in CELL_MODE_RANGE, which relies on the line editor instead.

This PR fixes that issue, but the Action Editor issue still remains as that happens due to the window getting unfocused and losing the reference to popup_edited_item.

@BlueCube3310 BlueCube3310 requested a review from a team as a code owner August 30, 2023 17:31
@Calinou Calinou added bug topic:gui cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 30, 2023
@Calinou Calinou added this to the 4.2 milestone Aug 30, 2023
@akien-mga akien-mga merged commit 0c7ac25 into godotengine:master Oct 2, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@BlueCube3310 BlueCube3310 deleted the tree-range-fix branch April 25, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control Tree range slider not working (also affects input action deadzone editor)
5 participants