Select node when clicked in AnimationPlayer timeline

[the-sink]

Implements suggestion made in godotengine/godot-proposals#7067. When clicking on the space on the left of the timeline group header that contains the icon & node name, it will select the node corresponding to that group.

godot.windows.editor.dev.x86_64_2023-08-30_22-07-40.mp4

Production edit: Closes godotengine/godot-proposals#7067

[TokageItLab]

It looks like a good improvement, but there are some concerns. In particular, we need to test if this behavior doesn't conflicts with AnimationTrack or Sprite2D which open the editor by selecting, and if it doesn't causes any problems during pinning.

[mieldepoche]

Some feedback:

• Maybe clicking on the icon in plain list mode should behave like that too?

simplescreenrecorder-2023-09-20_09.41.50.webm

• As mentioned above, some nodes can show their tool when selected:

an AnimatedSprite2D	an AnimationPlayer
simplescreenrecorder-2023-09-20_09.44.54.webm	simplescreenrecorder-2023-09-20_09.49.04.webm

[the-sink]

Hmm... all I can think of to fix that issue is to temporarily pin the window when the selection is being changed from in the animation editor, but that sounds a little hacky imo.

Also I noticed that most editors don't respect the pin? For instance, clicking on an AnimatedSprite2D to open the SpriteFrames editor while the animation editor is pinned still steals focus from the animation editor regardless. The TileMap editor also seems to ignore the pin (is it only meant to hold focus over other AnimationPlayers?)

[KoBeWi]

I think the pin is for pinning the AnimationPlayer itself, so that Animation tab does not switch when you click another AnimationPlayer (this is useful for animation tracks). It does not prevent other editors from getting into focus.

IMO context switching is not much related to this PR, because it would require changes to the editor in general. Also it happens only with a few specific nodes.

[akien-mga]

Thanks!