Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Native File Dialogs] Improve filter list handling, add selected filter to the callback. #81218

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[Native File Dialogs] Improve filter list handling, add selected filter to the callback. #81218

merged 1 commit into from
Oct 4, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 1, 2023 •
edited
Loading

Alternative version of #80842 with some additional features.

  • Adds more filter checks.
  • Adds mode value checks.
  • Handles *.x,*.y;X + Y filter as a single filter.
  • (macOS) Adds accessory view with the selectable filter list. Screenshot 2023-09-01 at 10 13 04
  • (Breaking Change) Adds an extra argument to the callback function, with current selected filter.

Fixes #80784

@bruvzg bruvzg added this to the 4.x milestone Sep 1, 2023
@bruvzg bruvzg marked this pull request as ready for review September 1, 2023 10:52
@bruvzg bruvzg requested review from a team as code owners September 1, 2023 10:52
@bruvzg bruvzg mentioned this pull request Sep 4, 2023
Merged
@bruvzg bruvzg mentioned this pull request Sep 17, 2023
Closed
This was referenced Sep 17, 2023
Closed
Closed
@bruvzg bruvzg mentioned this pull request Sep 30, 2023
Closed
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 3, 2023
@akien-mga
Copy link
Member

Since this supersedes #80952, does it also fix #80905?

@bruvzg
Copy link
Member Author

bruvzg commented Oct 3, 2023 •
edited
Loading

Since this supersedes #80952, does it also fix #80905?

It supersede #80842 not #80952 (seems like I have added a note to the wrong PR), so no it doesn't.

@akien-mga
Copy link
Member

Needs rebase.

@akien-mga akien-mga merged commit d5db0e5 into godotengine:master Oct 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Oct 11, 2023
Closed
@akien-mga akien-mga mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ePirat ePirat ePirat left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
breaks compat bug crash enhancement platform:linuxbsd platform:macos platform:windows topic:porting
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Executing DisplayServer.file_dialog_show function crashes Godot
3 participants
@bruvzg @akien-mga @ePirat