-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring primary line X/Ys separately #81255
Merged
akien-mga
merged 1 commit into
godotengine:master
from
JohnGabrielUK:primary-line-separate-xy
Sep 12, 2023
Merged
Allow configuring primary line X/Ys separately #81255
akien-mga
merged 1 commit into
godotengine:master
from
JohnGabrielUK:primary-line-separate-xy
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Sep 2, 2023
Calinou
reviewed
Sep 2, 2023
JohnGabrielUK
force-pushed
the
primary-line-separate-xy
branch
from
September 2, 2023 21:25
845f940
to
13d4c35
Compare
KoBeWi
reviewed
Sep 8, 2023
KoBeWi
reviewed
Sep 8, 2023
The implementation looks fine, but there is a concern of compatibility with old values. If someone set primary step values before, they will be lost after this PR. This code would handle it: #ifndef DISABLE_DEPRECATED
if (state.has("primary_grid_steps")) {
primary_grid_step_x = state["primary_grid_steps"];
primary_grid_step_y = state["primary_grid_steps"];
}
#endif (not sure if |
JohnGabrielUK
force-pushed
the
primary-line-separate-xy
branch
2 times, most recently
from
September 9, 2023 12:11
bcd8842
to
5bb4090
Compare
JohnGabrielUK
force-pushed
the
primary-line-separate-xy
branch
from
September 9, 2023 14:14
5bb4090
to
ba8ec07
Compare
KoBeWi
reviewed
Sep 9, 2023
KoBeWi
approved these changes
Sep 9, 2023
JohnGabrielUK
force-pushed
the
primary-line-separate-xy
branch
from
September 9, 2023 14:38
ba8ec07
to
0f9e94e
Compare
AThousandShips
approved these changes
Sep 12, 2023
JohnGabrielUK
force-pushed
the
primary-line-separate-xy
branch
from
September 12, 2023 09:24
0f9e94e
to
984eb96
Compare
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the feature outlined in this proposal, which at time of writing has yet to be approved.