-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clamping logic in EditorSpinSlider
#81278
Fix clamping logic in EditorSpinSlider
#81278
Conversation
EditorSpinSlider
...
... when arrow keys are pressed up or down.
33cc232
to
053d718
Compare
I already did this in #80551. I think I did it better; I have a few doubts about how it's implemented here but I'll have to test them out. |
ok, I would also like to catch Should I wait until 'merge' has been executed? #80551 |
Would suggest against it. Would lead to a lot of accidental value changes when one tries to adjust their inspector view. |
Nevermind, this PR works well in all situations, I think it's better than mine actually. So my PR can be closed, though I think my comments can be carried over to improve the clarity of the code.
|
EditorSpinSlider
...EditorSpinSlider
Thanks! |
... when arrow keys are pressed
up
ordown
.Fixes #81272
I have only tried
Inspertor
, I am not sure if the old changes are necessary for something else.The old version changed the values by 0.001 from time to time.
Screen-2023-09-03-200319.mp4