Add a button to clear curve points in the Path2D editor

[AttackButton]

• Create a get_points function in scene\resources\curve.h.
• Create clear_curve_points and restore_curve_points to handle the undo_redo system in the editor\plugins\path_2d_editor_plugin.h.
• Set the MODE_EDIT when entering the Path2D node, if a curve has already been created.
• Set the MODE_CREATE if the curve is valid, but empty.
• Added a confirmation dialog before clearing the points.
• Added the possibility to delete points in edit and edit curve modes.

[MewPurPur]

It's a bit more of a "danger" action and also the only one that does what you need in one click instead of needing to interact with the 2D editor. Maybe it should be in the Options dropdown instead?

[AttackButton]

I'm trying to close all the possibilities of undo_redo first (the hard part of the pr) to discuss this. I believe that the button is so different from the others and the user can still use ctrl+z.

[KoBeWi]

I think moving to to Options menu is better for 2 reasons:

• it's not something used often
• other buttons are for interacting with the path, this one isn't (although this applies to close curve too I guess...)
  Making destructive action more difficult to click accidentally is a bonus, but undoredo makes it irrelevant.

[AThousandShips]

You need to resolve the conflicts

[AttackButton]

History working and added a confirmation dialog before clearing the points.

[AttackButton]

Just finished. It's ready for review.

[KoBeWi]

The implementation looks alright, but not sure about the auto mode change. It might be annoying when editing multiple paths and you want to use another tool.

Also the clear operation doesn't need confirmation, because you can undo it.
Also I still think the popup menu might be better place to put it.

[AttackButton]

I agree with the auto mode change part. In fact, when editing multiple curves you may want to stick with the same mode. I'm going to remove it at least from the part when you select the Path2D node in the editor.

As a user, I can say that leaving this button exposed in the editor is very important. This may prevent someone from intuitively selecting all the curve points on the screen and pressing delete. Action that would attempt to delete the node from the tree.

[KoBeWi]

The second part of this comment was not addressed: #81325 (comment)

[AttackButton]

The second part of this comment was not addressed: #81325 (comment)

As I said before, leaving this button exposed is important because without it the user will not know how to clear the points. The confirmation dialog is necessary as the button will be exposed to users; furthermore, it resembles the node deletion action.

[KoBeWi]

The implementation looks ok.
Feature has no proposal.

[akien-mga]

Seems useful to me.

[akien-mga]

Thanks!

[Lu-TheCoder]

Hmm should this be happening??
I think something is broken...

issue.mp4

Godot 4.3 dev 5
Running on Mac M1

[KoBeWi]

That's #89781
Will be fixed in dev 6.