Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Compat checks: Make fetching the reference API more robust #81337

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

RedworkDE
Copy link
Member

The GDExtension compat checks have recently been occasionally warning about all entries in the expected file, presumably because the reference API file has failed to download.

Thus:

  • Switch wget from quiet to non-verbose mode so that in the future any such failures leave a trail in the log.
  • Enable wget's retrying for 503 responses (which presumably was the response from the cache server when the failures occurred)
  • Fail the CI step when the download still fails, as in that case the check cannot be executed.

@RedworkDE RedworkDE added this to the 4.2 milestone Sep 5, 2023
@RedworkDE RedworkDE requested a review from a team as a code owner September 5, 2023 12:18
@YuriSizov
Copy link
Contributor

I noticed it as well, thanks for a quick fix! Do we want to limit the number of retries? I seems to default to 20 IIUC, which is probably excessive. I'd say 3 should be enough.

@RedworkDE
Copy link
Member Author

I noticed that retry limit but I thought that the defaults are probably fine and left it at them.
I supposed if we ever run into a case where it gets stuck in the download we can still reduce the retry limit.

@YuriSizov
Copy link
Contributor

Well if it fails to download, 20 retries would just waste CI time. It's either a fluke, and a couple retries would fix it, or it's a problem and 20 retries won't change anything.

@YuriSizov YuriSizov changed the title CI: Compat checks: Make fetching the reference API more roboust CI: Compat checks: Make fetching the reference API more robust Sep 5, 2023
@RedworkDE
Copy link
Member Author

I reduced the maximum retries and timeout.

@YuriSizov YuriSizov merged commit 4ac6b64 into godotengine:master Sep 6, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@RedworkDE RedworkDE deleted the ci-compat-fetch branch September 6, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants