Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Fix live resize with the latest MoltenVK version. #81339

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[macOS] Fix live resize with the latest MoltenVK version. #81339

merged 1 commit into from
Sep 6, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 5, 2023

@bruvzg bruvzg added this to the 4.2 milestone Sep 5, 2023
@bruvzg bruvzg requested a review from a team as a code owner September 5, 2023 13:25
@bruvzg bruvzg mentioned this pull request Sep 5, 2023
Merged
@akien-mga akien-mga added the bug label Sep 5, 2023
@YuriSizov YuriSizov merged commit 0717663 into godotengine:master Sep 6, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@bruvzg bruvzg deleted the macos_fix_mvk_live_resize branch September 6, 2023 13:12
@aaronfranke
Copy link
Member

This PR fixed a critical bug I was experiencing where DisplayServer.window_set_mode was freezing the game, thanks!
(I'm mostly commenting here so that this PR will show up in a search for window_set_mode, as I searched for this earlier and could not find it, I only arrived here after a lot of troubleshooting and cherry-picking).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:macos topic:porting
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@bruvzg @YuriSizov @aaronfranke @akien-mga