Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid text substitution in EditorHelp messages #81346

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

timothyqiu
Copy link
Member

String There is currently no description for this %s. exists for different method types. Other types of elements have dedicated versions of this string without substitution.

This substitution may bring difficulties for localization. e.g. For languages that have gender for nouns. So I turned it into individual strings.

p.s. Also removed the unused EditorHelp::Page enum.

@MewPurPur
Copy link
Contributor

Seems unnecessary to have more code for a placeholder we ultimately want to erase from existence. Can't we just use "This description is currently missing."?

@YuriSizov
Copy link
Contributor

@MewPurPur There is nothing wrong with being verbose and less repetitive, and we'll always need these placeholders as long as the project is developed :)

@YuriSizov YuriSizov merged commit 3a585a6 into godotengine:master Sep 6, 2023
16 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@timothyqiu timothyqiu deleted the interning branch September 6, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants