Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a wireframe mode to BaseMaterial3D #81444

Closed

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Sep 8, 2023

Adds a boolean flag, so user may enable it on Base/StandardMaterial3D now.
sphere

@Chaosus Chaosus requested a review from a team as a code owner September 8, 2023 07:42
@Chaosus Chaosus added this to the 4.2 milestone Sep 8, 2023
@AThousandShips
Copy link
Member

AThousandShips commented Sep 8, 2023

The new flag constant wasn't registered, all previous ones have

@Chaosus Chaosus force-pushed the standard_material_wireframe branch from e2db83d to ae5b3b0 Compare September 8, 2023 07:52
@Chaosus
Copy link
Member Author

Chaosus commented Sep 8, 2023

The new flag constant wasn't registered, all previous ones have

Fixed

@Chaosus Chaosus force-pushed the standard_material_wireframe branch from ae5b3b0 to 84c6863 Compare September 8, 2023 07:54
@akien-mga
Copy link
Member

This looks interesting, but can you clarify the use case? Are there related proposals showing why users need this as a material property?

@Chaosus
Copy link
Member Author

Chaosus commented Sep 8, 2023

I think it may be useful for debugging + it's supported in common shaders, so this just a step for completion between the material and shader material functionality.

@akien-mga akien-mga requested a review from a team September 8, 2023 09:04
@clayjohn
Copy link
Member

clayjohn commented Sep 8, 2023

I don't think the wireframe mode is implemented in the GL_Compatibility renderer. We should probably hold off on merging this until it works with all backends.

@Chaosus Chaosus modified the milestones: 4.2, 4.x Sep 8, 2023
@Calinou
Copy link
Member

Calinou commented Sep 9, 2023

I suggest opening a proposal for this PR 🙂

@Chaosus
Copy link
Member Author

Chaosus commented Dec 8, 2023

I don't think the wireframe mode is implemented in the GL_Compatibility renderer. We should probably hold off on merging this until it works with all backends.

#85621 got merged, so this PR may be accepted too now?

@clayjohn
Copy link
Member

clayjohn commented Dec 8, 2023

I don't think the wireframe mode is implemented in the GL_Compatibility renderer. We should probably hold off on merging this until it works with all backends.

#85621 got merged, so this PR may be accepted too now?

Something we didn't think about before is that the Compatibility backend requires us to generate a different index array for wireframes. Therefore, its only enabled when requested by set_debug_generate_wireframes. So this toggle would appear to work in editor (because set_debug_generate_wireframes is called by EditorNode) and not at export time.

So I guess for this to work on the compatibility renderer we would need some additional flag to force generating the wireframe arrays when the mesh is used with a material that has wireframes force enabled.

@Chaosus
Copy link
Member Author

Chaosus commented Jun 14, 2024

So I guess for this to work on the compatibility renderer we would need some additional flag to force generating the wireframe arrays when the mesh is used with a material that has wireframes force enabled.

Okay, then I close it since it seems to be a far perspective..

@Chaosus Chaosus closed this Jun 14, 2024
@Chaosus Chaosus deleted the standard_material_wireframe branch June 14, 2024 10:28
@Chaosus Chaosus removed this from the 4.x milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants