-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a wireframe mode to BaseMaterial3D
#81444
Conversation
The new flag constant wasn't registered, all previous ones have |
e2db83d
to
ae5b3b0
Compare
Fixed |
ae5b3b0
to
84c6863
Compare
This looks interesting, but can you clarify the use case? Are there related proposals showing why users need this as a material property? |
I think it may be useful for debugging + it's supported in common shaders, so this just a step for completion between the material and shader material functionality. |
I don't think the wireframe mode is implemented in the GL_Compatibility renderer. We should probably hold off on merging this until it works with all backends. |
I suggest opening a proposal for this PR 🙂 |
#85621 got merged, so this PR may be accepted too now? |
Something we didn't think about before is that the Compatibility backend requires us to generate a different index array for wireframes. Therefore, its only enabled when requested by So I guess for this to work on the compatibility renderer we would need some additional flag to force generating the wireframe arrays when the mesh is used with a material that has wireframes force enabled. |
Okay, then I close it since it seems to be a far perspective.. |
Adds a boolean flag, so user may enable it on Base/StandardMaterial3D now.