Fix errors when testing Resource
#81456
Conversation
tests/core/io/test_resource.h
Outdated
| ERR_PRINT_OFF | ||
| ResourceSaver::save(resource_a, save_path_binary); | ||
| ResourceSaver::save(resource_a, save_path_text); | ||
| ERR_PRINT_ON |
There was a problem hiding this comment.
I'm not sure it's correct to silence those. The error message says "bug?", and that means either the message is wrong (this is a normal, expected failure from misusing the API) or there is a bug to be fixed.
There was a problem hiding this comment.
Then I'll just fix the has_meta and leave that for further investigation
There was a problem hiding this comment.
Tried investigating the exact details in the code when I was working on this yesterday, and wasn't sure exactly where to go with it
Now only fixing the get_meta part
The oddity is that the binary case stores the resource reference regardless, as it has parsed it all before storing, but it then gets a warning when reading, can silence that one but I think it might be considered an error that it stores cyclic references
The message in the text case should probably be fixed as well, as it might be missing some details.
Both cases do have seemingly cyclic error detection with dedicated messages but doesn't show up for these
Replaces `get_meta` with `has_meta` for cases where the meta is expected to be empty.
AThousandShips
force-pushed
the
test_fix
branch
from
d73c9a2
to
7726ed6
Compare
AThousandShips
changed the title
ResourceResource
|
Thanks! |
|
Thank you! |
Using
has_metainstead ofget_metawhere the result is expected to not exist.The warning and errors when saving and loading needs to be investigated, it appears that the binary case doesn't identify cycles like the text case does, and the text case errors but without indicating that it's a cyclic error.