-
-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3D editor gizmo icons for Decal, LightmapProbe and FogVolume #81554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2b7f70
to
c8a65d3
Compare
@Calinou does it make it selectable with box select too? |
Yes 🙂 |
c8a65d3
to
a910357
Compare
YuriSizov
reviewed
Sep 15, 2023
YuriSizov
reviewed
Sep 15, 2023
YuriSizov
reviewed
Sep 15, 2023
YuriSizov
reviewed
Sep 15, 2023
a910357
to
7ea4449
Compare
MewPurPur
reviewed
Sep 15, 2023
@MewPurPur You're brilliant! 🚀 |
- Tweak CPUParticles3D editor gizmo icon to use the same outline color as other gizmo icons. Make the internal icon easier to see by using an orange color instead of gray. Co-authored-by: MewPurPur <mew.pur.pur@abv.bg>
@MewPurPur Thanks a lot! I've added you as a co-author 🙂 |
7ea4449
to
5345cf3
Compare
YuriSizov
approved these changes
Sep 15, 2023
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lightmap probes that are automatically generated by LightmapGI don't have gizmo icons, as these are not nodes in the first place. Only manually authored LightmapProbe nodes have an icon.
Preview
Left: Decal, middle left: CPUParticles3D, middle right: GPUParticles3D, right: LightmapProbe
FogVolume: