Fix issue with OpenXR environment blend mode not being applied properly #81561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hitmuri please let me know if this solves your issue properly. |
BastiaanOlij
force-pushed
the
fix_openxr_blend_modes
branch
3 times, most recently
from
8fb5629 to
b9dd50b
Compare
Yes it works perfectly now. Thanks ! |
BastiaanOlij
force-pushed
the
fix_openxr_blend_modes
branch
from
b9dd50b to
3806d96
Compare
m4gr3d
approved these changes
Sep 13, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures environment blending is properly applied by setting the
XR_COMPOSITION_LAYER_BLEND_TEXTURE_SOURCE_ALPHA_BITflag if needed when submitting our images to OpenXR.While fixing this I also improved some of the checking and added a project settings flag for this.
Fixes #81338