Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dumping of signal API parameters #81599

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix dumping of signal API parameters #81599

merged 1 commit into from
Sep 14, 2023

Conversation

ShadowApex
Copy link
Contributor

@ShadowApex ShadowApex commented Sep 13, 2023 •
edited by dalexeev
Loading

This change fixes the issue referenced in #81598

When dumping signal parameters, the wrong index was being used.

Bugsquad edit: Fixes #81598.

@ShadowApex ShadowApex requested a review from a team as a code owner September 13, 2023 01:45
@Calinou Calinou added bug topic:gdscript crash cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 13, 2023
@Calinou Calinou added this to the 4.2 milestone Sep 13, 2023
dalexeev
dalexeev approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Language Server, but it looks like an obvious typo. Thank you for the fix!

@YuriSizov YuriSizov merged commit 1437b3a into godotengine:master Sep 14, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks, and congrats on your first merged Godot pull-request!

@ShadowApex ShadowApex deleted the shadowapex/fix-extendparser-signals branch September 14, 2023 15:42
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
bug crash topic:gdscript
Projects
None yet
Milestone
4.2
4 participants
@ShadowApex @YuriSizov @dalexeev @Calinou