Expose PopupMenu activate_item_by_event method
#81621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrecisionRender
force-pushed
the
fix-popup-menu-accelerators
branch
2 times, most recently
from
4438769
to
be7897e
Compare
|
@AThousandShips Could this be added to the 4.2 milestone? The reason I did this PR is because a serious project I'm working on depends on it. If not, I'll just use my own fork until it gets merged. |
|
If it gets approved soon it'll be added to it, but enhancements fit more on a flexible schedule |
Got it, thanks for the quick answer. |
|
I've tested this PR with my project. From what I can tell, everything works as intended. |
PrecisionRender
force-pushed
the
fix-popup-menu-accelerators
branch
from
c3c2cc7
to
2900ace
Compare
KoBeWi
reviewed
Sep 15, 2023
KoBeWi
approved these changes
Sep 15, 2023
PrecisionRender
force-pushed
the
fix-popup-menu-accelerators
branch
from
2900ace
to
76fad10
Compare
YuriSizov
approved these changes
Sep 15, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40836
Exposes the method that
Controls likeMenuButtonuse to propagate input information to thePopupMenu, so that accelerator and shortcut functionality isn't limited to thoseControls.