Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Include lambda dependencies #81629

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

rune-scape
Copy link
Contributor

theres no issue tracker, as the bug this fixes is very difficult to stumble on

  • includes dependencies of lambdas to script dependencies
  • also adds static initializer to dependencies

@rune-scape rune-scape requested a review from a team as a code owner September 13, 2023 21:44
@rune-scape
Copy link
Contributor Author

hmmm, the failed check seems like an unrelated crash...

@dalexeev dalexeev added this to the 4.2 milestone Sep 14, 2023
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is excellent, nice catch @rune-scape. If you could rename the functions to what they do, as commented, it would be awesome.

@akien-mga akien-mga merged commit 986c8af into godotengine:master Feb 12, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants