Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer updating the animations Tree in SpriteFramesEditor to avoid crashes #81643

Commits on Oct 17, 2023

  1. Defer updating the animations Tree in SpriteFramesEditor to avoid cra…

    …shes
    
    Previously, clicking the LMB while renaming an animation could cause
    `SpriteFramesEditor::_update_library(false)` to be called during
    `Tree::propagate_mouse_event()`. This may cause a crash.
    
    We can defer updates to the editor interface to avoid calling
    `Tree::create_item()` at the wrong time.
    
    Enables `SpriteFramesEditor::_select_animation()` to be able to undo/redo
    Rindbee committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    2642c68 View commit details
    Browse the repository at this point in the history