-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix folder moving in file system dock #81725
Merged
akien-mga
merged 1 commit into
godotengine:master
from
Rindbee:fix-folder-moving-in-FileSystemDock
Sep 29, 2023
Merged
Fix folder moving in file system dock #81725
akien-mga
merged 1 commit into
godotengine:master
from
Rindbee:fix-folder-moving-in-FileSystemDock
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rindbee
force-pushed
the
fix-folder-moving-in-FileSystemDock
branch
from
September 16, 2023 07:53
5e40d37
to
f5adbfc
Compare
Rindbee
force-pushed
the
fix-folder-moving-in-FileSystemDock
branch
2 times, most recently
from
September 16, 2023 08:16
3d73d08
to
fc36d9c
Compare
Rindbee
commented
Sep 16, 2023
Rindbee
force-pushed
the
fix-folder-moving-in-FileSystemDock
branch
from
September 16, 2023 09:56
fc36d9c
to
2073555
Compare
It's still possible to break dependencies if you rename a folder (tested with inherited scenes). Also doing specific steps, you can cause a crash:
godot.windows.editor.dev.x86_64_hzSjn067Sn.mp4(B inherits A) |
Rindbee
force-pushed
the
fix-folder-moving-in-FileSystemDock
branch
2 times, most recently
from
September 29, 2023 00:27
00e3164
to
6d7f6de
Compare
|
KoBeWi
reviewed
Sep 29, 2023
KoBeWi
approved these changes
Sep 29, 2023
Include files in the folder that will be moved/renamed when looking up the file owner. Rename the function/variable names to make more sense in FileSystemDock
Rindbee
force-pushed
the
fix-folder-moving-in-FileSystemDock
branch
from
September 29, 2023 12:32
6d7f6de
to
1cb1d7f
Compare
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include files in the folder that will be moved/renamed when looking up the file owner.
Fixed issue when moving/renaming directories, see #77289 (comment).
Rename the function/variable names to make more sense.