Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite a small comment in GDScript tokenizer code #81881

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Rewrite a small comment in GDScript tokenizer code #81881

merged 1 commit into from
Sep 20, 2023

Conversation

gio3k
Copy link
Contributor

@gio3k gio3k commented Sep 18, 2023

Just rewrote a little comment in the tokenizer code - it looked a little off when I initially saw it.

@gio3k gio3k requested a review from a team as a code owner September 18, 2023 20:59
@Calinou Calinou added this to the 4.x milestone Sep 18, 2023
@Anutrix
Copy link
Contributor

Anutrix commented Sep 19, 2023

@lotuspar Please squash commits into single commit. https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html#doc-pr-workflow might help.

adamscott
adamscott approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good rewrite, thanks!

@gio3k
Rewrite a bit of comment in tokenizer code
b6f1dbb 
gdscript_tokenizer.cpp: `change` -> `changes`
@gio3k
Copy link
Contributor Author

gio3k commented Sep 19, 2023

Squashed!

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Sep 19, 2023
@akien-mga akien-mga merged commit 888d325 into godotengine:master Sep 20, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:gdscript
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@gio3k @Anutrix @akien-mga @adamscott @Calinou