Remove unnecessary line from Projection::get_z_far
#81986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a line from Projection::get_z_far that flips the normal of a plane. While this may be required for similar code elsewhere in the file, this is unnecessary here, as only the length of the normal is used and not the direction. Flipping the normal does not change its magnitude and therefore is unnecessary in this case.
aaronfranke
approved these changes
Sep 20, 2023
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
akien-mga
changed the title
Projection::get_z_far
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes a line from Projection::get_z_far that flips the normal of a plane. While this may be required for similar code elsewhere in the file, this is unnecessary here, as only the length of the normal is used and not the direction. Flipping the normal does not change its magnitude and therefore is unnecessary in this case.