Make ShaderMaterial always the last option in inspector resource dropdowns #81996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
editor-shadermaterial-last-option
branch
from
d0a9fb4 to
f847a6e
Compare
Calinou
force-pushed
the
editor-shadermaterial-last-option
branch
from
f847a6e to
0ddc92a
Compare
|
This causes GDExtension compatibility errors, is this expected? I'm only changing the entries' order – no entry has been added or removed. |
|
Well anything that affects extension JSON is considered a compatibility breakage. You can just add it to the |
Except for CanvasItems, where ShaderMaterial is used most of the time (from my experience). |
KoBeWi
approved these changes
Feb 4, 2024
Calinou
force-pushed
the
editor-shadermaterial-last-option
branch
from
0ddc92a to
fa55333
Compare
…downs ShaderMaterial is the "advanced" option, while the "basic" options should be listed first for easier accessibility (and because they're generally used more often). This makes sky and particle materials consistent with canvas/spatial/fog materials on this aspect.
Calinou
force-pushed
the
editor-shadermaterial-last-option
branch
from
fa55333 to
93be97e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShaderMaterial is the "advanced" option, while the "basic" options should be listed first for easier accessibility (and because they're generally used more often).
This makes sky and particle materials consistent with canvas/spatial/fog materials on this aspect.