Animation: Fix reset value when adding new Bezier track #82012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TokageItLab I am not sure, but can you take a look at this animation reset value functionality for bezier tracks? |
TokageItLab
approved these changes
Jul 8, 2024
akien-mga
changed the title
Fixes godotengine#81929. In Float and Integer types, there is no subindex – only the primary value. Currently, trying to retrieve a subindex from these types in the Variant leads to a return value of null. To address this, the proposed change ensures that the default value is returned for these types instead of attempting an invalid subindex retrieval.
fire
approved these changes
Jul 8, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Float and Integer types, there is no subindex – only the primary value. Currently, trying to retrieve a subindex from these types in the Variant leads to a return value of null. To address this, the proposed change ensures that the default value is returned for these types instead of attempting an invalid subindex retrieval.