Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing clear for some set_exclude* query parameter methods #82043

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix missing clear for some set_exclude* query parameter methods #82043

merged 1 commit into from
Sep 21, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips added bug topic:physics cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 21, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Sep 21, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner September 21, 2023 11:33
akien-mga
akien-mga approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Slightly concerned about cherry-picking for 4.1 as this breaks the behavior of this API, which users might be using currently to append bodies instead of replace.

But since we don't expose a way to clear the exclude_bodies, I think it's worth cherry-picking as there's currently no workaround for 4.1 users (while they can reintroduce the existing behavior by appending with += if it works, or manually preparing a bigger array).

@AThousandShips
Copy link
Member Author

Was unsure if it should be added, we can leave it to decide later but I agree that without a way to clear it adding it there too makes sense

@akien-mga akien-mga merged commit fe5b1c8 into godotengine:master Sep 21, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the exclude_fix branch September 21, 2023 13:03
@AThousandShips
Copy link
Member Author

Thank you!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:physics
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

PhysicsTestMotionParameters2D doesn't clear existing RIDs when setting excludes
3 participants
@AThousandShips @akien-mga @YuriSizov