Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix incorrect GL format code for 16 bit float formats #82050

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

chokomancarr
Copy link
Contributor

For FORMAT_XXXH half-precision format constants, the GL-equivalent format was written as GL_XXX32F. This fixes it to GL_XXX16F to align with the intended precision.

For FORMAT_XXXH half-precision format constants, the description uses GL_XXX32F, which is incorrect.
This fixes it to GL_XXX16F to align with the intended precision.
@chokomancarr chokomancarr requested a review from a team as a code owner September 21, 2023 13:51
@chokomancarr chokomancarr marked this pull request as draft September 21, 2023 13:53
@chokomancarr chokomancarr marked this pull request as ready for review September 21, 2023 13:54
@akien-mga akien-mga changed the title fix incorrect GL format code for 16 bit float formats Fix incorrect GL format code for 16 bit float formats Sep 21, 2023
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems correct, the previous values must have been copy paste mistakes.

@akien-mga akien-mga changed the title Fix incorrect GL format code for 16 bit float formats docs: Fix incorrect GL format code for 16 bit float formats Sep 21, 2023
@akien-mga akien-mga added bug documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 21, 2023
@akien-mga akien-mga added this to the 4.2 milestone Sep 21, 2023
@akien-mga akien-mga merged commit 317b925 into godotengine:master Sep 24, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@chokomancarr chokomancarr deleted the patch-1 branch October 30, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants