Enable scrolling of output with UI scale changes #82079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:editor
topic:gui
cherrypick:4.1
|
Can this be reviewed and merged. Causing inconvenience in debugging. |
AThousandShips
added
the
cherrypick:4.2
Calinou
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Tested locally (rebased on top of master 4c96e96), it works as expected.
Scales tested: 75%, 100%, 115%, 125%, 150%, 175%, 200%
Please squash the commits together so we can merge this. See PR workflow for instructions 🙂
RoyBerube
force-pushed
the
OutputScroll
branch
from
3cddc88
to
a7b2e09
Compare
|
Commits are now squashed down to one commit. |
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.1. |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82041
Changing the UI custom scale could prevent editor output window from scrolling.
Cause: The logic for determining to scroll the editor output window could be adversely affected by the UI custom scaling.
Solution: Added rounding to vscroll->getpage() within the logic for determining if the output window should scroll.