Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Export] Fix TextServer data export. #82103

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 22, 2023

Fixes #82062

@bruvzg bruvzg added this to the 4.2 milestone Sep 22, 2023
@Koyper
Copy link
Contributor

Koyper commented Sep 24, 2023

On MacOS(arm64) I'm getting a crash running an export debug per below with Include Text Server Data enabled, but it runs successfully when disabled. The project also runs without the PR, and with Include Text Server Data enabled.

This is with 4.2dev5(c12d635)

handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.2.dev.custom_build (787fa14a90d0a85205539581f191e0933be2896b)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] 1   libsystem_platform.dylib            0x00007ff8094b45ed _sigtramp + 29
[2] 2   ???                                 0x00000000000001ba 0x0 + 442
[3] 3   ExportDebug                              0x000000010734b741 udata_openChoice_73_godot + 1217
[4] 4   ExportDebug                              0x000000010734aff5 udata_open_73_godot + 1621
[5] res_load_73_godot (in ExportDebug) + 67
[6] 6   ExportDebug                              0x000000010736c914 ures_openDirect_73_godot + 5588
[7] 7   ExportDebug                              0x000000010736bff6 ures_openDirect_73_godot + 3254
[8] 8   ExportDebug                              0x000000010736acfc ures_getLocaleByType_73_godot + 684
[9] icu_73_godot::BreakIterator::buildInstance(icu_73_godot::Locale const&, char const*, UErrorCode&) (in ExportDebug) + 157
[10] icu_73_godot::BreakIterator::makeInstance(icu_73_godot::Locale const&, int, UErrorCode&) (in ExportDebug) + 677
[11] ubrk_open_73_godot (in ExportDebug) + 151
[12] TextServerAdvanced::_shaped_text_update_breaks(RID const&) (in ExportDebug) + 995
[13] TextServer::shaped_text_get_line_breaks(RID const&, double, long long, BitField<TextServer::LineBreakFlag>) const (in ExportDebug) + 62
[14] TextServerExtension::shaped_text_get_line_breaks(RID const&, double, long long, BitField<TextServer::LineBreakFlag>) const (in ExportDebug) + 1114
[15] TextParagraph::_shape_lines() (in ExportDebug) + 2355
[16] TextParagraph::get_size() const (in ExportDebug) + 44
[17] Button::get_minimum_size_for_text_and_icon(String const&, Ref<Texture2D>) const (in ExportDebug) + 292
[18] Button::get_minimum_size() const (in ExportDebug) + 281
[19] Control::get_combined_minimum_size() const (in ExportDebug) + 67
[20] Control::_size_changed() (in ExportDebug) + 161
[21] Button::~Button()
[22] Object::notification(int, bool) (in ExportDebug) + 62
[23] CanvasItem::_notification(int) (in ExportDebug) + 1460
[24] Button::~Button()
[25] Object::notification(int, bool) (in ExportDebug) + 62
[26] Node::_propagate_enter_tree() (in ExportDebug) + 223
[27] Node::_propagate_enter_tree() (in ExportDebug) + 618
[28] Node::_propagate_enter_tree() (in ExportDebug) + 618
[29] Node::_set_tree(SceneTree*) (in ExportDebug) + 66
[30] OS_MacOS::run() (in ExportDebug) + 45
[31] main (in ExportDebug) + 312
[32] 32  dyld                                0x000000020918441f start + 1903
-- END OF BACKTRACE --

@akien-mga akien-mga merged commit 1376a5a into godotengine:master Oct 3, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS->shaped_text_prev_character_pos ignored by LineEdit and TextEdit in exports only
3 participants