-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add call validation to CommandPalette #82194
Merged
akien-mga
merged 1 commit into
godotengine:master
from
KoBeWi:your_command_failed._Good_luck_finding_out_why
Sep 25, 2023
Merged
Add call validation to CommandPalette #82194
akien-mga
merged 1 commit into
godotengine:master
from
KoBeWi:your_command_failed._Good_luck_finding_out_why
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
reviewed
Sep 23, 2023
I would probably use a toast for this. I don't see a reason to raise a blocking popup. But otherwise seems like a good idea! |
KoBeWi
force-pushed
the
your_command_failed._Good_luck_finding_out_why
branch
from
September 23, 2023 15:09
343a9e9
to
abd4652
Compare
KoBeWi
force-pushed
the
your_command_failed._Good_luck_finding_out_why
branch
from
September 23, 2023 15:13
abd4652
to
7d52d9f
Compare
YuriSizov
approved these changes
Sep 23, 2023
Fails building:
|
I know, but I can't decipher the error. |
|
KoBeWi
force-pushed
the
your_command_failed._Good_luck_finding_out_why
branch
from
September 24, 2023 22:10
7d52d9f
to
9f0b8c0
Compare
I added |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code from confused user™:
The EditorScript instance is gone before the command is run, so it can't be called. However editor palette doesn't do any call validation and it just fails silently.
This PR adds error messages: