Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blender importer: allow Blender 4 executables #82211

Closed
wants to merge 1 commit into from

Conversation

benthillerkus
Copy link

Blender 4 is currently scheduled to release in ~6 weeks, so it'd be nice to be able to already test the importer with the new version.

@benthillerkus benthillerkus requested a review from a team as a code owner September 23, 2023 20:03
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice any breakage?

@@ -322,7 +322,7 @@ static bool _test_blender_path(const String &p_path, String *r_err = nullptr) {
}
return false;
}
if (version > 3) {
if (version > 4) {
if (r_err) {
*r_err = TTR("This Blender installation is too new for this importer (not 3.x).");
Copy link
Member

@AThousandShips AThousandShips Sep 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message needs to be updated

@Calinou
Copy link
Member

Calinou commented Sep 23, 2023

#81194 needs to be merged first, or this won't work.

@rcorre
Copy link
Contributor

rcorre commented Sep 24, 2023

#81194 actually removes the upper-bound version check entirely.

@akien-mga
Copy link
Member

Superseded by #81194.

@akien-mga akien-mga closed this Oct 6, 2023
@benthillerkus benthillerkus deleted the patch-1 branch October 7, 2023 05:56
@AThousandShips AThousandShips removed this from the 4.x milestone Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants