Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the separator from ItemList's thumbnails mode #82236

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Remove the separator from ItemList's thumbnails mode #82236

merged 1 commit into from
Sep 24, 2023

Conversation

Chubercik
Copy link
Contributor

@Chubercik Chubercik commented Sep 24, 2023 •
edited
Loading

Fixes #81787.

This pull request removes separators which appear when ItemList's icon_mode is set to ICON_MODE_TOP (thumbnails mode).

See the mentioned issue to see how things were before; after fix:

godot_separator

@Chubercik Chubercik requested a review from a team as a code owner September 24, 2023 11:18
@AThousandShips AThousandShips added this to the 4.2 milestone Sep 24, 2023
@MewPurPur
Copy link
Contributor

Helps with #80793 but doesn't fix it

akien-mga
akien-mga approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@akien-mga akien-mga merged commit df0a822 into godotengine:master Sep 24, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chubercik Chubercik deleted the item_list_separator_fix branch September 24, 2023 22:38
@Chubercik Chubercik mentioned this pull request Oct 28, 2023
Merged
@havi05 havi05 mentioned this pull request Sep 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Thin separator line between filesystem items in split mode
4 participants
@Chubercik @MewPurPur @akien-mga @AThousandShips