C#: Use HashCode.Combine()
for basic composite types instead of xor
#82240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector2I.GetHashCode() creates hash conflicts if X and Y concide:
(0, 0) => 0.GetHashCode() ^ 0.GetHashCode() == 0
(1, 1) => 1.GetHashCode() ^ 1.GetHashCode() == 0
(2, 2) => 2.GetHashCode() ^ 2.GetHashCode() == 0
Let's use
HashCode.Combine(X, Y)
instead. It will combine hash codes properly and minimize conflicts.