Fix can't unset exported typed array element when the type is set to Node #82287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 25, 2023
|
Thanks! |
jsjtxietian
deleted the
fix-clear-error-when-unset-exported-typed-array-vai-editor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82034
The code failed at
ERR_FAIL_COND(!_p->typed.validate(value, "set")), NodePath can't be set to a TypedArray of type 'Object'.I guess the easy way to fix this is what this pr did, make
_node_clearemit an empty variant instead of an empty node_path. But it might has unexpected impacts, I would appreciate any feedback or alternative suggestions.