Updated compiler version detection #82325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes multiple issues/inconsistencies around `get_compiler_version()`: * With no shell allocated, launching the compiler could fail even with proper paths being set. * The return value was described as "an array of version numbers as ints", but the function actually returned a `Dictionary` (or `None`). * Not all calls were properly handling a `None` return value in case of errors. On Windows this broke compiling for me since godotengine#81869 with default settings. * Some calls defined inconsistent defaults/fallbacks (`0` or `-1`).
akien-mga
approved these changes
Sep 25, 2023
akien-mga
added
enhancement
topic:buildsystem
cherrypick:3.x
|
Thanks! |
|
This breaks macOS build. |
Addition of |
|
Cherry-picked for 4.1.3. |
YuriSizov
removed
the
cherrypick:4.1
akien-mga
removed
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes multiple issues/inconsistencies around
get_compiler_version():Dictionary(orNone).Nonereturn value in case of errors. On Windows this broke compiling for me since Web: Fix version check for missing scalbnf LTO workaround #81869 with default settings.0or-1).While I verified these changes under Windows, I currently don't have a build environment for Linux or MacOS ready.