Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of notification_func #82332

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

Sauermann
Copy link
Contributor

fix comment #78634 (comment)
cc @dsnopek

@Sauermann Sauermann added this to the 4.2 milestone Sep 25, 2023
@Sauermann Sauermann requested a review from a team as a code owner September 25, 2023 20:49
@dsnopek dsnopek removed the crash label Sep 25, 2023
@Gallilus
Copy link
Contributor

Pulled the Gun too early with my approval. My issue seems solved by initializing to nullptr.

struct {
		GDExtensionScriptInstanceNotification notification_func = nullptr;
	} deprecated_native_info;

@dsnopek dsnopek added the crash label Sep 25, 2023
@dsnopek
Copy link
Contributor

dsnopek commented Sep 25, 2023

@Gallilus Ack, I think you're right! We're only initializing that value if you call script_instance_create, but not if you call script_instance_create2. Good catch!

@Sauermann If you don't mind adding the = nullptr, we can fix two problems at once :-)

@Sauermann
Copy link
Contributor Author

Of course. done.

Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@akien-mga akien-mga merged commit 7e67b49 into godotengine:master Sep 26, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Sauermann Sauermann deleted the fix-struct-type branch September 26, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants