Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in dev assert in NavMeshGenerator2D #82368

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix typo in dev assert in NavMeshGenerator2D #82368

merged 1 commit into from
Sep 26, 2023

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Sep 26, 2023

Found as I couldn't compile, got warning treated as error.

@kleonc kleonc added this to the 4.2 milestone Sep 26, 2023
@kleonc kleonc requested a review from smix8 September 26, 2023 12:39
smix8
smix8 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@smix8 smix8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was kinda a silly mistake considering I copied from the 3D generator.

@AThousandShips AThousandShips mentioned this pull request Sep 26, 2023
Closed
@AThousandShips
Copy link
Member

(fails without #82375)

@AThousandShips AThousandShips mentioned this pull request Sep 26, 2023
Merged
@akien-mga akien-mga merged commit e0b1171 into godotengine:master Sep 26, 2023
14 of 15 checks passed
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the NavMeshGenerator2D-dev-assert-assignment-typo branch September 26, 2023 16:07
@akien-mga akien-mga mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smix8 smix8 smix8 approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:navigation topic:2d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@kleonc @AThousandShips @akien-mga @smix8