Fix performance regression in RigidBody2D/3D and PhysicalBone3D #82393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calBone3D After change godotengine@c118256 the body state is synched 2x, but this is only needed if _integrate_forces is overridden. Adding this extra if increases the FPS by 2.5% in a heavy physics scene, see: godot-jolt/godot-jolt#611
akien-mga
changed the title
|
Hello, since this is my first PR: Do I need to do anything to progress this PR? Do I need to notify the reviewers somehow? |
|
You don't need to do anything specific, but it wasn't a bad idea to poke as this looks like something I can approve myself :) |
akien-mga
approved these changes
Oct 3, 2023
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After change #79977 the body state is synched 2x per frame, but this is only needed if _integrate_forces is overridden.
Adding this extra if increases the FPS by 2.5% in a heavy physics scene, see discussion at: godot-jolt/godot-jolt#611