-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that resource_name
is not always supported
#82406
Document that resource_name
is not always supported
#82406
Conversation
5ff960b
to
4fdeeec
Compare
ece07b1
to
5256eaf
Compare
resource_name
is not always supported
Needs some adjustments to the note. Also, could you please amend the commit message to follow our prefer format (starts with a verb describing the action, followed by the subject of the change)? The current title of the PR is a good option. |
No, I could not. I've had my suggested change shot down three times now, for a one line doc change, and now you want the commit message changed too (not mentione after it was ignored for months). I've lost all enthusiasm for driving this forward. Clearly things must be done exactly right here, and I don't know how, so you can sort it out yourselves. |
That's understandable. We have both a significant backlog to review with limited resources, and high quality standards to ensure that what gets merged is correct and does not add to tech debt that would be hard to manage with scale. It's totally ok to opt out of the process if it's too cumbersome, we understand it's not for everyone. Do you mind if we take over this PR to do the final touches ourselves so that it can be merged? |
Feel free |
Closes godotengine#82333. Co-authored-by: Yuri Sizov <11782833+YuriSizov@users.noreply.github.com>
a8f11f3
to
a390996
Compare
Thanks! And congrats for your first merged Godot contribution 🎉 |
Warning about the problem described in #82333
Bugsquad edit: